Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy empty metadata file not deployable #667

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Make sure file are copied only when they still contains metadata for InFile metadata definition

Does this close any currently open issues?


closes #665

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

Any particular element that can be tested locally


Add a custom label file with one label in it and commit
Then remove the label definition in the custom label file and commit
Then run sgd with HEAD~1

@scolladon
Copy link
Owner Author

Hi @RohitGagan16,

Could you test this PR locally with your context and let me know if it does fix the issue #665 please ?

You can follow those steps to run the plugin locally with the current branch

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e348a75) 100.00% compared to head (b28e798) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #667   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          894       900    +6     
=========================================
+ Hits           894       900    +6     
Files Changed Coverage Δ
src/service/ObjectTranslationHandler.js 100.00% <100.00%> (ø)
src/service/botHandler.js 100.00% <100.00%> (ø)
src/service/inFileHandler.js 100.00% <100.00%> (ø)
src/service/standardHandler.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the fix/empty-custom-label-deletion branch from f441386 to b28e798 Compare August 5, 2023 19:31
@codeclimate
Copy link

codeclimate bot commented Aug 5, 2023

Code Climate has analyzed commit b28e798 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 2d5c60c into main Aug 8, 2023
19 checks passed
@scolladon scolladon deleted the fix/empty-custom-label-deletion branch August 8, 2023 07:17
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Shipped in release v5.24.2.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.24.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting any custom label from the source folder creates Custom Label file in the delta directory.
1 participant