Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API manual #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update API manual #419

wants to merge 1 commit into from

Conversation

Mornor
Copy link

@Mornor Mornor commented Oct 26, 2016

I wasn't able to update a check without sending the state in the body payload.

I wasn't able to update a check without sending the `state` in the body payload.
@alenkacz
Copy link
Contributor

@Mornor do you still have the error that you received when not providing this value?

@Mornor
Copy link
Author

Mornor commented Oct 26, 2016

@alenkacz : I got a HTTP 500 internal server error.
When added, a 200 was returned.
I cannot re-test it tonight unfortunately, but can hopefully tell you more tomorrow.

@alenkacz
Copy link
Contributor

@Mornor I did not find anything in code that would actually require this but I am not familiar with that part of the code so maybe testing it myself would be the easiest thing :)

@nisc-acooper
Copy link

This is pretty old, but I can say we ran into this as well. The actual exception is below. I will continue to look for a fix so state is not required to be passed. It doesnt make much sense to require it, and passing it could create unintentional false positives or false negatives.

java.lang.NullPointerException com.seyren.mongo.MongoStore.saveCheck(MongoStore.java:238) com.seyren.api.bean.ChecksBean.updateCheck(ChecksBean.java:81) sun.reflect.GeneratedMethodAccessor338.invoke(Unknown Source) sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants