-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amazon Web Services (AWS) SNS Support #418
base: master
Are you sure you want to change the base?
Conversation
@scobal let me know what you think and whether this could make the next release. Thanks. |
Looks great... Have you thought about adding a link back to the Seyren Check in the msg... something like: |
@mazurio Given your particular use case, it might be prudent to add a configuration option that would allow the URL to be inserted or left out... As you know, SNS is very flexible, and can be used to forward messages to many different destinations, many of which I can see a high use case for having a link to the check. I can figure out the implementation details if you don't want to work on that part of it, though figured you already have a PR open... up to you. :) |
Makes sense :) I will add it tomorrow as it's quite late here already - unless you want to add it first then feel free to do so! |
@mazurio LGTM! :) |
@alenkacz any update on this? Looks like it was good to merge last year? |
SNS_REGION
config.