Formating param values error #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added data provider dependency for testing in gradle Fixed error in formating values Added unit test for ParamTypeResolver class
|
@enriclluelles @albertoramirezscmspain @cristiangarciascmspain Thanks! |
Closed
| @Test | ||
| @UseDataProvider("dataProviderAdd") | ||
| public void testResolveValueType(Class<T> type, String value) throws Exception { | ||
|
|
There was a problem hiding this comment.
That seems really better than previous version we was working on!!!
|
👍 |
| { Short.class, "2" }, | ||
| { Float.class, "27.42" }, | ||
| { Double.class, "42.42" } | ||
|
|
There was a problem hiding this comment.
if I add:
{ boolean.class, "true" },
{ long.class, "27" },
{ int.class, "42" },the test fails.
Is this an error?
There was a problem hiding this comment.
I'd also add some negative test cases in order to document the behavior when somebody call Resolver with things like
SomeExoticClass.class, "whatever value"
… can not resolve to the given class
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in gitignore a release version of build.gradle
Added data provider dependency for testing in gradle
Fixed error in formating values
Added unit test for ParamTypeResolver class