Skip to content

Add container PyTest to Ruby Container #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add container PyTest to Ruby Container #608

wants to merge 5 commits into from
+804 −435

Conversation

@phracek
Copy link
Member

@phracek phracek commented Nov 6, 2025 •
edited by github-actions bot
Loading

Add Container PyTest suite to s2i-ruby container.
Migration matrix is following:

For db, puma, rack applications are classes:
db -> TestRubyHelloWorldContainer
puma -> TestRubyPumaTestAppContainer
rack -> TestRubyRackTestAppContainer

test_docker_run_usage -> test_container_basics.py->TestS2IRubyContainer(test_docker_run_usage)
test_application -> test_application in each class
test_connection -> test_application in each class in assert
test_response -> test_application in each class in assert
test_scl_usage -> test_container_basics.py->TestS2IRubyContainer(test_scl_usage)
test_npm_functionality -> test_container_basics.py->TestRubyNPMtestContainer
test_ruby_fips_mode -> test_container_fips.py->TestRubyFipsModeContainer(test_fips_mode)
test_ruby_fips_s2i_app -> test_container_fips.TestRubyFipsApplicationContainer(test_application)
test_from_dockerfile -> test_container_basics.py -> TestS2IRubyContainer(test_dockerfiles)
test_from_dockerfile.s2i -> test_container_basics.py -> TestS2IRubyContainer(test_dockerfiles)

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • Testing Farm - RHEL9 - FIPS Enabled - 3.0[pending]
  • Testing Farm - RHEL10 - FIPS Enabled - 3.3[pending]
  • Testing Farm - Fedora - 3.3[pending]
  • Testing Farm - RHEL9 - 3.3[pending]
  • Testing Farm - CentOS Stream 10 - 3.3[pending]
  • Testing Farm - RHEL8 - 2.5[pending]
  • Testing Farm - RHEL9 - FIPS Enabled - 3.3[pending]
  • Testing Farm - RHEL10 - 3.3[pending]
  • Testing Farm - RHEL8 - 3.3[pending]
  • Testing Farm - RHEL9 - PyTest - 3.3[pending]
  • Testing Farm - CentOS Stream 10 - PyTest - 3.3[pending]
  • Testing Farm - RHEL8 - PyTest - 2.5[pending]
  • Testing Farm - Fedora - PyTest - 3.3[pending]
  • Testing Farm - RHEL8 - PyTest - 3.3[pending]
  • Testing Farm - RHEL9 - 3.0[pending]
  • Testing Farm - RHEL10 - PyTest - 3.3[pending]
  • Testing Farm - RHEL8 - PyTest - OpenShift 4 - 2.5[pending]
  • Testing Farm - RHEL8 - OpenShift 4 - 3.3[pending]

🔴 Review - Missing review from a member (1 required)

@phracek
Rename OpenShift PyTest files to test_ocp_*.py
d491434 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Add Container PyTest suite to s2i-ruby container.
21776e9 
Migration matrix is following:

For db, puma, rack applications are classes:
db -> TestRubyHelloWorldContainer
puma -> TestRubyPumaTestAppContainer
rack -> TestRubyRackTestAppContainer

test_docker_run_usage -> test_container_basics.py->TestS2IRubyContainer(test_docker_run_usage)

test_application -> test_application in each class

test_connection -> test_application in each class in assert

test_response -> test_application in each class in assert

test_scl_usage -> test_container_basics.py->TestS2IRubyContainer(test_scl_usage)

test_npm_functionality -> test_container_basics.py->TestRubyNPMtestContainer

test_ruby_fips_mode ->
test_container_fips.py->TestRubyFipsModeContainer(test_fips_mode)

test_ruby_fips_s2i_app ->
test_container_fips.TestRubyFipsApplicationContainer(test_application)

test_from_dockerfile -> test_container_basics.py ->
TestS2IRubyContainer(test_dockerfiles)

test_from_dockerfile.s2i -> test_container_basics.py ->
TestS2IRubyContainer(test_dockerfiles)

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Nov 6, 2025

[test-pytest][test-openshift-pytest]

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - PyTest - 3.3Fedora-latestx86_64✅ passed18.11.2025 15:35:237min 48stest pipeline
RHEL10 - PyTest - OpenShift 4 - 3.3RHEL-10-Nightlyx86_64✅ passed18.11.2025 15:45:4321min 26stest pipeline
CentOS Stream 10 - PyTest - 3.3CentOS-Stream-10x86_64✅ passed18.11.2025 15:35:2210min 59stest pipeline
RHEL8 - PyTest - OpenShift 4 - 2.5RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:35:3734min 49stest pipeline
RHEL8 - PyTest - OpenShift 4 - 3.3RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:36:4122min 4stest pipeline
RHEL9 - PyTest - OpenShift 4 - 3.3RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:47:4326min 48stest pipeline
RHEL8 - PyTest - 3.3RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:35:2716min 38stest pipeline
RHEL9 - PyTest - OpenShift 4 - 3.0RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:36:0348min 37stest pipeline
RHEL9 - PyTest - 3.3RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:35:2022min 5stest pipeline
RHEL8 - PyTest - 2.5RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:35:2321min 8stest pipeline
RHEL9 - PyTest - 3.0RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:47:4626min 41stest pipeline
RHEL10 - PyTest - 3.3RHEL-10-Nightlyx86_64✅ passed18.11.2025 15:35:3217min 32stest pipeline
Fedora - 3.3Fedora-latestx86_64✅ passed18.11.2025 15:35:138min 55stest pipeline
CentOS Stream 10 - 3.3CentOS-Stream-10x86_64✅ passed18.11.2025 15:35:1411min 4stest pipeline
RHEL10 - 3.3RHEL-10-Nightlyx86_64✅ passed18.11.2025 15:35:1717min 21stest pipeline
RHEL8 - 3.3RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:35:1717min 2stest pipeline
RHEL10 - FIPS Enabled - 3.3RHEL-10-Nightlyx86_64✅ passed18.11.2025 15:35:1220min 46stest pipeline
RHEL8 - OpenShift 4 - 3.3RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:35:5021min 23stest pipeline
RHEL9 - 3.3RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:35:1323min 20stest pipeline
RHEL8 - 2.5RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:35:1522min 13stest pipeline
RHEL9 - 3.0RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:35:3228min 50stest pipeline
RHEL9 - FIPS Enabled - 3.3RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:35:1630min 23stest pipeline
RHEL9 - OpenShift 4 - 3.3RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:43:5126min 14stest pipeline
RHEL9 - FIPS Enabled - 3.0RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:35:1238min 14stest pipeline
RHEL10 - OpenShift 4 - 3.3RHEL-10-Nightlyx86_64✅ passed18.11.2025 15:53:5920min 34stest pipeline
RHEL8 - OpenShift 4 - 2.5RHEL-8.10.0-Nightlyx86_64✅ passed18.11.2025 15:53:5827min 55stest pipeline
RHEL9 - OpenShift 4 - 3.0RHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 15:54:0235min 9stest pipeline

@phracek
Fix OpenShift 4 PyTest and add missing docstring.
6a40ee4 
Do not run FIPS tests on RHEL8

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Fix missing symlink to conftest.py in each directory.
69acf3b 
Fix skipping RHEL8 tests for FIPS.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Nov 7, 2025

[test-pytest][test-openshift-pytest]

@phracek phracek requested a review from jackorp November 7, 2025 10:39
@phracek
Refactoring tests suite to class.
d60e021 
Build app once and test it.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Nov 18, 2025

[test-all]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackorp jackorp Awaiting requested review from jackorp

Assignees

No one assigned

Labels

pr/failing-ci pr/missing-review ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phracek