OpenShift 4 tests for for shared_cluster #734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
Testing Farm results
|
phracek
force-pushed
the
fix_openshift_tests
branch
from
5bbdea8 to
52fc536
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
phracek
force-pushed
the
fix_openshift_tests
branch
from
93b412c to
f62af89
Compare
|
Fix obsoleted version and branch [test-openshift][test-openshift-pytest] |
frenzymadness
requested changes
May 7, 2025
|
Let's try to test it after modifications [test-openshift][test-openshift-pytest] |
|
Fix missing dist-gen generated files [test-openshift][test-openshift-pytest] |
|
@frenzymadness One more review please. |
There was a problem hiding this comment.
It looks good now but there is one thing I don't understand: what is the benefit of having BRANCH_TO_TEST and BRANCH_TO_MASTER as individual variables?
Currently we have here:
from constants import BRANCH_TO_MASTER
…
BRANCH_TO_TEST = BRANCH_TO_MASTER
…
if something:
BRANCH_TO_TEST = "fooo"
…
while it can be simplified into something like:
from constants import BRANCH_TO_TEST
…
if something:
BRANCH_TO_TEST = "fooo"
…
Or I might not understand what the name BRANCH_TO_MASTER means.
Also, it would be nice to have a clean history and some of the changes are spread across multiple commits now.
|
Rebased against master, squashed commits into three commits. [test-openshift][test-openshift-pytest] |
I still see 14 commits. |
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Replace function `template_deployed` -> `is_template_deployed` Do not use 'curl' test for HelmCharts. It does not make sense Remove deduplicate function into alone python file Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
fix_openshift_tests
branch
from
27175a7 to
cd486ad
Compare
I see sorry, it was a typo on my side. Now only 3 commits. [test-openshift][test-openshift-pytest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.