[WIP] First try of conu test implementation#198
[WIP] First try of conu test implementation#198hhorak wants to merge 2 commits intosclorg:masterfrom
Conversation
|
@TomasTomecek, FYI, we might chat about this sometime. |
TomasTomecek
left a comment
TomasTomecek
left a comment
There was a problem hiding this comment.
you probably forgot to include Dockerfile.tests in this PR
otherwise lgtm, but I'm assuming you want to talk to me
| include common/common.mk | ||
|
|
||
| build-test-container: | ||
| docker build --network host --tag=$(TEST_IMAGE_NAME) -f ./test/Dockerfile.tests . |
There was a problem hiding this comment.
Dockerfile.tests seems to be missing
| app.rmi() | ||
|
|
||
|
|
||
| class GenericTestSuite: |
There was a problem hiding this comment.
I'm assuming you want this class to be in conu :)
There was a problem hiding this comment.
Yes, that was the intention, but I did not go far enough to propose it as a PR.
| backend = DockerBackend(logging_level=logging.DEBUG) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="module", params=app_paths) |
There was a problem hiding this comment.
and we could also start shipping some fine-crafted pytest fixtures in conu
Since there is no pressure to have this PR finished asap, I'd like rather to do the changes in |
|
We have disabled conu in RHSCL CI testing. Closing this issue. |
3 participants
Based on sclorg/s2i-ruby-container#167 with slight generalization. The point here is to see how much of the tests we can actually generalize, and put into conu library. It seems quite a lot.