Skip to content

Building testing pushing c8s support #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2022

Conversation

phracek
Copy link
Member

@phracek phracek commented Apr 19, 2022

This pull request adds support for building, and testing CentOS Stream 8 postgresql-container.
It also adds support for pushing images into quay.io/sclorg repositories.

What is the difference between 13/Dockerfile.rhel8 and 13/Dockerfile.c8s:

$ diff 13/Dockerfile.rhel8 13/Dockerfile.c8s
1c1
< FROM ubi8/s2i-core
---
> FROM quay.io/sclorg/s2i-core-c8s:c8s
13a14
>     POSTGRESQL_PREV_VERSION=12 \
30c31
<       name="rhel8/postgresql-13" \
---
>       name="sclorg/postgresql-13-c8s" \
33,34c34
<       com.redhat.license_terms="https://www.redhat.com/en/about/red-hat-end-user-license-agreements#rhel" \
<       usage="podman run -d --name postgresql_database -e POSTGRESQL_USER=user -e POSTGRESQL_PASSWORD=pass -e POSTGRESQL_DATABASE=db -p 5432:5432 rhel8/postgresql-13" \
---
>       usage="podman run -d --name postgresql_database -e POSTGRESQL_USER=user -e POSTGRESQL_PASSWORD=pass -e POSTGRESQL_DATABASE=db -p 5432:5432 sclorg/postgresql-13-c8s" \
49c49

What is the difference between 10/Dockerfile.rhel8 and 10/Dockerfile.c8s:

$ diff 10/Dockerfile.rhel8 10/Dockerfile.c8s
1c1
< FROM ubi8/s2i-core
---
> FROM quay.io/sclorg/s2i-core-c8s:c8s
31c31
<       name="rhel8/postgresql-10" \
---
>       name="sclorg/postgresql-10-c8s" \
34,35c34
<       com.redhat.license_terms="https://www.redhat.com/en/about/red-hat-end-user-license-agreements#rhel" \
<       usage="podman run -d --name postgresql_database -e POSTGRESQL_USER=user -e POSTGRESQL_PASSWORD=pass -e POSTGRESQL_DATABASE=db -p 5432:5432 rhel8/postgresql-10" \
---
>       usage="podman run -d --name postgresql_database -e POSTGRESQL_USER=user -e POSTGRESQL_PASSWORD=pass -e POSTGRESQL_DATABASE=db -p 5432:5432 sclorg/postgresql-10-c8s" \
49c48

@phracek phracek requested review from fila43, hhorak and pkubatrh April 28, 2022 11:57
@phracek phracek force-pushed the building_testing_pushing_c8s_support branch from 1ffc61e to e879c49 Compare May 2, 2022 11:27
phracek added 3 commits May 2, 2022 13:28
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the building_testing_pushing_c8s_support branch from e879c49 to 2c2f8c7 Compare May 2, 2022 11:29
@phracek
Copy link
Member Author

phracek commented May 2, 2022

[test-all]

@fila43
Copy link
Member

fila43 commented May 3, 2022

It makes sense to me and tests passed LGTM

@phracek phracek merged commit 9279b65 into master May 3, 2022
@zmiklank zmiklank deleted the building_testing_pushing_c8s_support branch November 23, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants