chore(dependencies): update for symfony #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop support for PHP 7.3, add PHP 8.1. Drop support for legacy symfony versions, add support for new version 6. close #21
Update year in copyright notice.
m-bymike
force-pushed
the
chore_dependencies
branch
from
ffcdfc2 to
8d228d3
Compare
xvilo
reviewed
Mar 14, 2022
| "php": "7.3.*|7.4.*|8.0.*", | ||
| "symfony/console": "3.4.*|4.4.*|5.*", | ||
| "symfony/finder": "3.4.*|4.4.*|5.*", | ||
| "php": "7.4.*|8.0.*|8.1.*", |
There was a problem hiding this comment.
Is there a reason why you wouldn't want to just do:
"php": "^7.4 || ^8.0",
This eases out maintenance and future compatibility
There was a problem hiding this comment.
Thank you for the suggestion, but it's a deliberate choice. I really prefer to run the test suite against any new version before releasing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for PHP 7.3, add PHP 8.1. Drop support for legacy symfony versions, add support for new version 6.
close #21