Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds plus and minus icons in text-soft and blue style #1502

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Adds plus and minus icons in text-soft and blue style #1502

merged 2 commits into from
Feb 7, 2025

Conversation

mko-sci
Copy link
Contributor

@mko-sci mko-sci commented Feb 7, 2025

Description

Example Use-Case:
Bildschirmfoto 2025-02-07 um 11 27 35

Additional Notes

  • This PR fixes or works on following ticket(s): OX-11760

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

@mko-sci mko-sci added 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review labels Feb 7, 2025
sabieber
sabieber approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@sabieber sabieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhhh, would call the classes the same as the icon files. Would reduce possible confusion.

@mko-sci
Renames minus and plus classes to match svg file names
9ea99cd 
Prevents confusion in the future.

Fixes: OX-11760
@mko-sci mko-sci merged commit 455838c into develop Feb 7, 2025
3 checks passed
@mko-sci mko-sci deleted the feature/mko/OX-11760 branch February 7, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@idlira idlira idlira approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mko-sci @sabieber @fhaScireum @idlira @ymo-sci @mkeckmkeck