prevent scrolling to the fake-element inserted for copy-buttons #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some rare cases the top-scroll value does not fit to the real scroll-position. So vie preventScroll we ask the browser to not scroll on focus
sabieber
approved these changes
Jan 30, 2025
idlira
approved these changes
Jan 30, 2025
fhaScireum
approved these changes
Jan 30, 2025
mkeckmkeck
approved these changes
Jan 30, 2025
mko-sci
approved these changes
Jan 30, 2025
jmuscireum
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic for copying values via copy-button is quiet weird, but "the-way-to-go" for all browsers and all cases (http, https).
in some rare cases (where scrollPaddingTop is set) the top-scroll value does not fit to the real scroll-position. So vie preventScroll we ask the browser to not scroll on focus. Is also not supported by all browsers, but does not break the functionality
Checklist