MAINT: ensure zero sign is returned for tangd at multiples of 180 and for cotdg at multiples of 90#153
Open
j-bowhay wants to merge 1 commit into
Open
MAINT: ensure zero sign is returned for tangd at multiples of 180 and for cotdg at multiples of 90#153j-bowhay wants to merge 1 commit into
j-bowhay wants to merge 1 commit into
Conversation
… cotdp at multiples of 90
Member
Author
|
CI failures are unrelated |
dschmitz89
changed the title
dschmitz89
reviewed
May 20, 2026
dschmitz89
reviewed
May 20, 2026
Comment on lines
105
to
+107
| /* modulo 180 */ | ||
| x = x - 180.0 * std::floor(x / 180.0); | ||
| double k = std::floor(x / 180.0); | ||
| x = x - 180.0 * k; |
Contributor
There was a problem hiding this comment.
Is it possible to simplify here with std::fmod?
Member
Author
|
It is also worth noting the cotdg is not listed in the IEE standard but it is fairly straight forward to determine what special values it should return based on how tangd is defined. I also checked these against Julia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
towards scipy/scipy#20731
What does this implement/fix?
Ensures the following special values from the IEE spec are returned
I will have a follow-up PR for the poles.
Additional information
AI Generation Disclosure
No AI