Ensure everything compiles individually & sort includes #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added a couple missing includes, so that every *.cpp or *.hpp file in the repository can now be compiled individually. I also grouped all includes (by stdlib/external libs/libff) and sorted them. instruction_packing_gadget was deleted because it did not compile, was clearly incompatible with the current codebase, and was not used anywhere. According to Madars, it was used in a previous version of the reduction.
|
LGTM, and indeed needed. Let's merge. In the future please try to break changes into separate commits (e.g., removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in libff pull request 9, I have made every file in libsnark compile individually by adding all missing includes, and also sorted all includes.
I also fixed a couple of places where references to functions/variables from libff were not properly namespaced.
I also deleted
libsnark/gadgetlib1/gadgets/cpu_checkers/tinyram/components/instruction_packing_gadget.{hpp,tcc}. These files did not compile, contained references to names that did not actually exist, and were not even included from anywhere. According to Madars, these files used to be a part of a previous implementation of the reduction, and don't have any purpose any more.