Skip to content

Refactor includes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2017
Merged

Refactor includes #3

merged 4 commits into from
Jun 27, 2017

Conversation

aleksejspopovs
Copy link
Collaborator

@aleksejspopovs aleksejspopovs commented Jun 20, 2017

This pull request is related to pull request 7 in libff.

This change makes it clear and explicit when files being included come from an external library, libff.

This pull request (as well as the accompanying ones in libsnark and libff) was largely generated using a Python script.

There is no need to add src/ to the list of include directories, as
all includes are relative.
This removes the need to add libff's source root to our include path,
and makes includes clearer and less ambiguous.
Relative includes starting with ".." are discouraged. Namespacing includes
explicitly reduces ambiguity.
@aleksejspopovs
Copy link
Collaborator Author

I updated this pull request, so it is now relevant again in the context of pull request 8 in libff.

@howardwu
Copy link
Member

LGTM. Builds and passes tests - make check output:

Test project /home/vagrant/libfqfft-a89c54a27dfb2d8182ed29c41a6e36b1fca8f238/build
    Start 1: gtests
1/1 Test #1: gtests ...........................   Passed    0.04 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   0.10 sec
[100%] Built target check

@madars madars merged commit 43c472e into scipr-lab:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants