Fix FMT #5
Closed
Fix FMT #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change resulted in the type of FMT(...) being void when DEBUG is enabled, instead of char*. The libsnark compilation issue is actually unrelated to this, and should be resolved by removing the unnecessary "libff::" from libsnark source code when calling FMT, as macros cannot be namespaced. This reverts commit 693fcc6.
|
Oh wait, this only fixes the !DEBUG case. Apologies, closing the pull request to fix DEBUG too. |
mobileink
added a commit
to minatools/libff
that referenced
this pull request
Jul 20, 2020
# This is the 1st commit message: bazel support, initial commit Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#2: gitignore .bazelrc, bazel-* Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#3: remove sha256 from rule_foreign_cc rule Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#4: rename target ff to libff Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#5: put curves/mnt/mnt4, 6 in separate packages Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#6: bn128: drop "depends" from include prefix, for bazel compatibility Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#7: fix refs to targets mnt4, mnt6, libff Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#8: fix refs to @ate_pairing//:libgmp Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#9: change @// to // Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#10: delete obsolete mnt4, mnt6 targets from curves/mnt/BUILD.bazel Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#11: add target scalar_multiplication:multiexp_profile Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#12: list headers explicitly Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#13: dead code elim Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#14: dead code elim Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#15: BUILD files: explicitate srcs/hdrs, DCE, buildifier reformat Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#16: change @ate_pairing//:zm to @ate_pairing//ate-pairing Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#17: switch obazl repos from local to git Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#18: pin xbyak, ate-pairing repos to versions, to match upstream Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#19: delete git submodules, not needed with Bazel Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#20: add sha256 for xbyak, ate-pairing external repos Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#21: remove xbyak dep - it's included in ate-pairing Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com> # This is the commit message scipr-lab#22: restore depends dirs Signed-off-by: Gregg Reynolds <601396+mobileink@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with the FMT macro:
it evaluated to values of different types (char* or void) based on whether DEBUG was on, when it should always evaluate to a char*
it could not be used outside of the libff namespace, because it would be expanded into UNUSED, which is a function inside the libff namespace.
The latter is a bigger problem, because macros really don't play well with namespaces. But these changes at least make it possible to use FMT outside libff (e.g. in libsnark).