Add data property on results that returns a DataGroup #119
+67
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
reviewed
Feb 2, 2026
src/tof/result.py
Outdated
| return sc.DataGroup( | ||
| { | ||
| key: value.data | ||
| for key, value in chain(self.choppers.items(), self.detectors.items()) |
Member
There was a problem hiding this comment.
It might be nice if we can sort the names by the distance from the source.
Member
Author
There was a problem hiding this comment.
Should we also add in the data from the source?
YooSunYoung
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
.dataproperty to theResultobject returned fromModel.run().It is similar to the
.dataproperty for component readings, but it returns a data group with one data entry for each component.