Fix docs build and update Zoom workflow #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Jul 3, 2024
| return monitors | ||
|
|
||
|
|
||
| def get_time_dependent_incident( |
There was a problem hiding this comment.
Nice that we could now remove this 👍
| @@ -311,7 +292,7 @@ | |||
| "metadata": {}, | |||
| "outputs": [], | |||
| "source": [ | |||
| "func = pol_workflow.compute(pol.he3.He3TransmissionFunction[pol.Analyzer])" | |||
| "func = pol_workflow.compute(pol.TransmissionFunction[pol.Analyzer])" | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Changes look fine but it seems the notebook is not run in the documentation build (in the built docs from CI run at least).
There was a problem hiding this comment.
Yes, sorry, I should have been clearer: The notebook requires Mantid, so it does not run in the actually docs build on CI.
There was a problem hiding this comment.
And I guess you don't want to install Mantid because you want to use tox and pip...
nvaytet
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zoom notebook contained a mermaid diagram, which caused a Sphinx warning... and the notebook was never executed. Therefore, we did not notice that it was not refactored for the current Sciline release.