Split code into more sensible parts #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some long-overdue maintenance: I moved all code relating to He3-cells to a
he3submodule. Inbaseremain the largely unused/untested components for processing run logs and extracting sections of data.I expect that we will later add other modules, e.g., for non-He3 cases, etc.
I have left the top-level imports unchanged for now, but we should consider removing the more specific ones. That is, access, e.g.,
pol.he3.He3TransmissionFunctioninstead ofpol.He3TransmissionFunction. This will make it easier to import only the pieces required for a specific beamline, depending on what types of polarizers and analyzers are in use.There are no functional changes here, just bits moved around.