Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotated detector pixel offset based on the starting position. #85

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

YooSunYoung
Copy link
Member

We were assuming the first pixel is always at (0,0,0) but it was not the case.

I added this to be included.

I didn't clean up the code or write more tests because this geometry parsing will be obsolete soon.

@YooSunYoung YooSunYoung added the bug Something isn't working label Sep 27, 2024
@jokasimr jokasimr self-assigned this Sep 30, 2024
Copy link
Contributor

@jokasimr jokasimr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the position_offset vectors the offsets of the pixels from the origin of the detector coordinate system? In that case, should they not be rotated with the detector?

Is the detector rotation matrix a rotation around the detectors own axis, or a rotation of the detector around the sample?

@jokasimr
Copy link
Contributor

@SimonHeybrock suggested merging this even if there are some question marks since it's mainly for testing anyway.

@jokasimr jokasimr merged commit ef0d80e into main Sep 30, 2024
3 checks passed
@jokasimr jokasimr deleted the fix-geometry branch September 30, 2024 08:46
@YooSunYoung
Copy link
Member Author

Are the position_offset vectors the offsets of the pixels from the origin of the detector coordinate system? In that case, should they not be rotated with the detector?

Yes. position_offset is not rotated.

Is the detector rotation matrix a rotation around the detectors own axis, or a rotation of the detector around the sample?

It's a rotation around the detector's own axis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants