Repository navigation
Job orchestrator #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Job orchestrator #540
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
dc0d560
Draft JobOrchestrator ideas
SimonHeybrock e6efe7a
Context notes and thoughts
SimonHeybrock f7acccf
Implement JobOrchestrator for workflow lifecycle management
SimonHeybrock bfcaea9
Implement job stop logic in JobOrchestrator.commit_workflow
SimonHeybrock b0431bd
Move config persistence from WorkflowController to JobOrchestrator
SimonHeybrock beb7943
Clean up WorkflowController.start_workflow: remove dead code and simp…
SimonHeybrock 95b019e
Fix bug and refactor JobOrchestrator to initialize all workflows with…
SimonHeybrock 417f990
Fix JobOrchestrator to handle workflows with required params (correla…
SimonHeybrock 581d728
Remove all workflow status methods and fields from WorkflowController…
SimonHeybrock b27850b
Refactor commit_workflow to return list[JobId] instead of JobNumber
SimonHeybrock ae85017
Refactor JobOrchestrator methods to use keyword-only arguments
SimonHeybrock 6c5e092
Simplify JobOrchestrator by removing unnecessary Pydantic validation
SimonHeybrock 3b159f0
Remove remaining pointless ConfigurationState validation in JobOrches…
SimonHeybrock be926e8
Remove unused methods from JobOrchestrator
SimonHeybrock 57b02cd
Refactor JobSet to encapsulate job number generation and JobId creation.
SimonHeybrock e900e80
Simplify job_number assignment in commit_workflow
SimonHeybrock 99e23e4
Refactor WorkflowConfig.from_params to only accept dicts
SimonHeybrock 47c8654
Remove draft
SimonHeybrock 22a69ec
Fix mutation safety issues in JobOrchestrator
SimonHeybrock d1b4133
Remove unused _workflow_specs_callbacks from WorkflowController
SimonHeybrock b3b75e0
Remove confusing docstring part
SimonHeybrock b005cf9
Remove unused status callback code from FakeWorkflowConfigService
SimonHeybrock c12cbeb
Remove unnecessary JobSet.add_job method
SimonHeybrock 3c17c23
Comment and add more tests
SimonHeybrock fed2e2d
Fix YAML serialization error for enum values in JobOrchestrator
SimonHeybrock 49a2201
Address PR #540 review comments
SimonHeybrock d96897c
Fix integration tests broken by source name validation
SimonHeybrock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note which briefly explains why the parameters are now just a dict and no longer Pydantic models? (Is it because dicts are easier to serialize if we want to persist them?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The params are still a model in
WorkflowSpec. The only difference is that the code that callsfrom_paramsnow has a dict instead of a model (and might not know the model directly). I don't think it would be correct to explain this here, as it is just history.