Update lookup table generating tool using tof. #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Jun 2, 2025
| ")\n", | ||
| "# Set tof simulation parameters\n", | ||
| "wf[DiskChoppers[SampleRun]] = sc.DataGroup(disk_choppers) # Mapping of chopper names to `DisckChopper` objects\n", | ||
| "wf[Position[snx.NXsource, SampleRun]] = sc.vector([0, 0, 0], unit='m') # Position of the source, which is usually at the origin\n", |
There was a problem hiding this comment.
No, the source is usually not at the origin. It looks like the hard-coded choppers in the package are placed relative to the source, i.e., with the source in the origin. But that will not be the case when we load them from NeXus.
So leave the parameter but please remove/update the comment.
| "id": "12", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "## Load the file" |
There was a problem hiding this comment.
Why did you add this here? This notebook is not a user-guide. That is what https://scipp.github.io/essreduce/user-guide/tof/index.html is for. Can you instead put a link to that page at the top of the notebook?
There was a problem hiding this comment.
I wanted to link to an example that uses the time_of_flight.TofLutProvider.FILE mode but I couldn't find one...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CL needed this and the current notebook didn't work with the latest packages anymore.
I just updated it to be same as the one I made for easyimaging.