fix: set credentials in all test/docs workflows #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
requested changes
Jul 11, 2024
template/.github/workflows/docs.yml
Outdated
| name: Build documentation | ||
| runs-on: 'ubuntu-22.04' | ||
| env: | ||
| # Security note! The secrets are only added to workflows that run on trusted branches (main). If secrets are accessible in workflows that run on untrusted branches they can be extracted, see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#exfiltrating-data-from-a-runner. |
Member
There was a problem hiding this comment.
This comment is no longer correct
jl-wynen
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to scipp/scippneutron#476
This change was already merged. But then we learnt some new things about when github secrets are available in workflows. They are not available in fork PRs.
This lets us simplify things by exposing the credentials in all
testanddocsactions. This removes the limitation that existed before, where only some actions could have access to secrets. Now alltestsanddocsactions will have access to protected files, unless they run in a fork PR.More information in this MR to the DMSC docs: https://git.esss.dk/docs/dmsc/-/merge_requests/31/.
I also got some feedback that maybe this stuff should not go here in the generic copier template at all, but rather in the ESS specific copier template. That should also be addressed but I think it's better to do it in a separate PR.