Skip to content

pyproject.toml: New #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 18, 2023
Merged

pyproject.toml: New #628

merged 4 commits into from
Feb 18, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Nov 13, 2022

Fixes #626

@mkoeppe mkoeppe mentioned this pull request Nov 13, 2022
Closed
@wkschwartz
Copy link
Contributor

Can probably update INSTALL.md to remove the instructions to pip install cython wheel

@mkoeppe mkoeppe mentioned this pull request Nov 23, 2022
Open
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2023

@mattmilten @wkschwartz ping

wkschwartz
wkschwartz reviewed Feb 18, 2023
View reviewed changes
Copy link
Contributor

@wkschwartz wkschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough familiarity with pyscipopt to opine on the list of requirements itself beyond what I see in this patch set

@mkoeppe @wkschwartz
Update pyproject.toml
399f3a6 
Co-authored-by: William Schwartz <wkschwartz@gmail.com>
@mattmilten
Copy link
Collaborator

Thanks a lot!

@mattmilten mattmilten merged commit 38f1387 into scipopt:master Feb 18, 2023
@mkoeppe mkoeppe deleted the pep517 branch February 18, 2023 23:29
@mkoeppe mkoeppe mentioned this pull request Feb 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkschwartz wkschwartz wkschwartz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declare build dependencies in pyproject.toml
3 participants
@mkoeppe @wkschwartz @mattmilten