JMK add option with call instead of check_call to allow fault for wsl #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pconesa
reviewed
Aug 7, 2024
| @@ -297,7 +299,8 @@ def renameGpuIds(self): | |||
|
|
|||
| logger.debug("Updated gpus ids rebase starting from 0: %s per thread" %self.gpuDict) | |||
|
|
|||
| def runJob(self, log, programName, params, numberOfMpi=1, numberOfThreads=1, env=None, cwd=None, executable=None): | |||
| def runJob(self, log, programName, params, numberOfMpi=1, numberOfThreads=1, env=None, cwd=None, | |||
There was a problem hiding this comment.
When running the protocol using Slurm or similar the protocol is not going to work.
There was a problem hiding this comment.
Can we make a note about that somehow?
pconesa
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows protocols that close programs in wsl with segfaults to still finish rather than raising errors