-
Notifications
You must be signed in to change notification settings - Fork 176
cmd/scion-pki: add certificate template command #4815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oncilla
wants to merge
1
commit into
scionproto:master
Choose a base branch
from
oncilla:scion-pki-template
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| // Copyright 2025 Anapaya Systems | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package certs | ||
|
|
||
| import ( | ||
| "crypto/x509" | ||
| "crypto/x509/pkix" | ||
| "encoding/json" | ||
| "encoding/pem" | ||
| "fmt" | ||
| "os" | ||
|
|
||
| "github.com/scionproto/scion/pkg/scrypto/cppki" | ||
| "github.com/scionproto/scion/private/app/command" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func newTemplateCmd(_ command.Pather) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "template", | ||
| Short: "Create subject template from a certificate or CSR", | ||
| Long: `'template' creates a subject template from a certificate, certificate chain, or CSR. | ||
|
|
||
| This command allows reconstructing the subject template that was used to cerate a certificate | ||
| or a certificate signing request (CSR). It is not necessary to use this command to create a | ||
| new certificate or CSR, as the template to the 'create' command can also be a certificate | ||
| itself. | ||
|
|
||
| In case the input is a certificate chain, the template is created from the first certificate | ||
| in the chain. | ||
| `, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| subject, err := loadPkixNameFromFile(args[0]) | ||
| if err != nil { | ||
| return fmt.Errorf("loading subject from file %q: %w", args[0], err) | ||
| } | ||
|
|
||
| ia, err := cppki.ExtractIA(subject) | ||
| if err != nil { | ||
| return fmt.Errorf("extracting ISD-AS from certificate: %w", err) | ||
| } | ||
|
|
||
| maybe := func(v []string) string { | ||
| if len(v) == 0 { | ||
| return "" | ||
| } | ||
| return v[0] | ||
| } | ||
| vars := SubjectVars{ | ||
| IA: ia, | ||
| CommonName: subject.CommonName, | ||
| Organization: maybe(subject.Organization), | ||
| Country: maybe(subject.Country), | ||
| Province: maybe(subject.Province), | ||
| Locality: maybe(subject.Locality), | ||
| OrganizationalUnit: maybe(subject.OrganizationalUnit), | ||
| PostalCode: maybe(subject.PostalCode), | ||
| StreetAddress: maybe(subject.StreetAddress), | ||
| SerialNumber: subject.SerialNumber, | ||
| } | ||
| enc := json.NewEncoder(cmd.OutOrStdout()) | ||
| enc.SetIndent("", " ") | ||
| if err := enc.Encode(vars); err != nil { | ||
| return fmt.Errorf("encoding template: %w", err) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
| return cmd | ||
| } | ||
|
|
||
| func loadPkixNameFromFile(filename string) (pkix.Name, error) { | ||
| raw, err := os.ReadFile(filename) | ||
| if err != nil { | ||
| return pkix.Name{}, fmt.Errorf("reading file %q: %w", filename, err) | ||
| } | ||
| return loadPkixNameFromRaw(raw) | ||
| } | ||
|
|
||
| func loadPkixNameFromRaw(raw []byte) (pkix.Name, error) { | ||
| pemData, _ := pem.Decode(raw) | ||
| if pemData == nil { | ||
| return pkix.Name{}, fmt.Errorf("not valid PEM") | ||
| } | ||
| switch pemData.Type { | ||
| case "CERTIFICATE": | ||
| cert, err := x509.ParseCertificate(pemData.Bytes) | ||
| if err != nil { | ||
| return pkix.Name{}, fmt.Errorf("parsing certificate: %w", err) | ||
| } | ||
| return cert.Subject, nil | ||
| case "CERTIFICATE REQUEST": | ||
| csr, err := x509.ParseCertificateRequest(pemData.Bytes) | ||
| if err != nil { | ||
| return pkix.Name{}, fmt.Errorf("parsing CSR: %w", err) | ||
| } | ||
| return csr.Subject, nil | ||
| default: | ||
| return pkix.Name{}, fmt.Errorf("invalid PEM block type %q", pemData.Type) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.