Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace interface{} with any #4684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romshark
Copy link
Contributor

This is the result of running:

find . -name "*.go" ! -exec grep -q "// Code generated" {} \; -exec gofmt -w -r 'interface{} -> any' {} +

It safely replaces all usage of interface{} with any, excluding generated files and is hence a purely cosmetic change.

Also see golang/go#49884

@romshark romshark added the refactor Change that focuses around reducing tech debt label Jan 24, 2025
@romshark romshark requested review from oncilla and a team as code owners January 24, 2025 16:25
@jiceatscion
Copy link
Contributor

This change is Reviewable

Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I support this.

Reviewed 72 of 73 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla and @romshark)


a discussion (no related file):
I shouldn't be the sole approver of a scion assoc PR. So I add this to prevent approval until there's another one.

Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla and @romshark)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants