Update jaeger all-in-one image to 1.14 #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.12 for me tried to allocate all the ram which would result in the machine no longer reacting. With 1.14 I no longer saw this behavior. Also use the new tmp volume (see jaegertracing/jaeger#1571)
oncilla
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
lukedirtwalker
added a commit
to lukedirtwalker/scion
that referenced
this pull request
Sep 10, 2019
In scionproto#3128 we switched to temp storage, but that is deleted after calling down on the container. That would mean on CI we can't access the traces, therefore switch back to the old storage approach. Also update the version in scion.sh
lukedirtwalker
added a commit
that referenced
this pull request
Sep 10, 2019
In #3128 we switched to temp storage, but that is deleted after calling down on the container. That would mean on CI we can't access the traces, therefore switch back to the old storage approach. Also update the version in scion.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.12 for me tried to allocate all the ram which would result in the machine no longer reacting.
With 1.14 I no longer saw this behavior.
Also use the new tmp volume (see jaegertracing/jaeger#1571)
This change is