Skip to content

Include package name in the identifier of decorated task#139

Merged
superstar54 merged 4 commits intomainfrom
fix_task_identifier
Jan 14, 2026
Merged

Include package name in the identifier of decorated task#139
superstar54 merged 4 commits intomainfrom
fix_task_identifier

Conversation

@superstar54
Copy link
Collaborator

@superstar54 superstar54 commented Jan 14, 2026

Add SocketAnnotated for annotated Python types without an explicit mapping.

When a task input/output is annotated with a Python type, the socket identifier is resolved from the type mapping. If the type is not mapped, the socket falls back to node_graph.annotated and records the Python type in metadata. If no annotation, fall back to SocketAny.

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 92.63158% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.46%. Comparing base (4226b08) to head (b0e5911).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_graph/socket_spec.py 91.66% 4 Missing ⚠️
tests/test_link.py 86.36% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #139    +/-   ##
========================================
  Coverage   90.45%   90.46%            
========================================
  Files          79       79            
  Lines        8134     8236   +102     
========================================
+ Hits         7358     7451    +93     
- Misses        776      785     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- add node_graph.annotated socket and entry point
- infer annotated types into metadata-backed sockets
- enforce annotated type mismatch errors in links
- strip Optional[T] to T during spec inference
@superstar54 superstar54 merged commit a086f16 into main Jan 14, 2026
13 checks passed
@superstar54 superstar54 deleted the fix_task_identifier branch January 14, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant