Merged
Conversation
superstar54
requested changes
Dec 2, 2025
Collaborator
superstar54
left a comment
There was a problem hiding this comment.
Thanks for the fix! I add two minor suggestions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 90.46% 90.54% +0.07%
==========================================
Files 73 73
Lines 7088 7125 +37
==========================================
+ Hits 6412 6451 +39
+ Misses 676 674 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Xing Wang <xingwang1991@gmail.com>
Collaborator
Author
|
I think we still need the |
superstar54
reviewed
Dec 2, 2025
Co-authored-by: Xing Wang <xingwang1991@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #131
As discussed in the above issue, when tasks are run, their links are evaluated, which take precedence over input values directly set, leading to confusing behaviour where you can set and view values that are disregarded.
At the point where these values are set in
_set_socket_value, it doesn't seem to be entirely straightforward to determine whether the update is being triggered by an update to the linked value, or if a value that should be linked is being directly set (and so ignored).My solution has therefore been to check, for inputs, whether the input being changed corresponds to one in the socket links.
As discussed with @superstar54, the
test_operationandtest_operation_comparisonwere not testing quite what we expected, sincetask.executedoes not resolve links, which meant that removingresult._task.set_inputs({"x": 4, "y": 2})raises a key error.I've updated these to run using a local engine, giving the expected behaviour, and added new tests that check that we can set unlinked values, but not linked values.