fix rst errors for pypi #7800
Merged
fix rst errors for pypi #7800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
indeed, this seems to be the source of the error. If you compare the state of README.rst on Sept 5th to the file on Oct 13, the line seems to be gone. Looks like it was accidentally removed in a1eb062, which was committed on Sept 22 (between 0.18RC2 and 0.18), hence why one works and the other doesn't. |
|
thanks :) |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Nov 9, 2016
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #7781
What does this implement/fix? Explain your changes.
I used rst-lint to check the Readme.rst
Is showed that we forgot a blank line after the first line to comply with rst format. It also explains why it's working on github and not on pyPI since the first line is a markup added for github.
I cleaned it.
Any other comments?