Treat warnings as errors in tests #280
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
Enable that warnings are treated as errors in the testsuite.
I fixed a couple of warnings in main code that would probably hit us badly in the next release of sklearn...
Also, I adjusted some tests for catching warnings using the
pytest.warnscontext manager but there are a lot more. Maybe if @cajchristian or someone else from @rosecers' team can help with fixing them. Almost all of them are very easy to fixContributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--280.org.readthedocs.build/en/280/