Removing kernel optimization from who example #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PicoCentauri
approved these changes
Apr 24, 2023
Collaborator
PicoCentauri
left a comment
PicoCentauri
left a comment
There was a problem hiding this comment.
Yes, very nice and much faster. I added a switch with recalc=False that users can easily set to True to rerun the search locally.
PicoCentauri
force-pushed
the
speedup-who
branch
from
1c19327 to
0c3dbad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I thought in #175, kernel optimization is a serious bottlebeck. @PicoCentauri can you see if this speeds things up significantly?
📚 Documentation preview 📚: https://scikit-matter--189.org.readthedocs.build/en/189/