Skip to content

Conversation

@Luthaf
Copy link
Collaborator

@Luthaf Luthaf commented Jun 20, 2022

I don't see a reason for limiting the number of points we can select to n_available - 1, especially since we can also request a fractional in the (0, 1] range

@Luthaf Luthaf requested a review from rosecers June 20, 2022 13:39
@rosecers rosecers merged commit 888395a into scikit-learn-contrib:main Jun 28, 2022
@Luthaf Luthaf deleted the select-all-points branch June 28, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants