Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Add fixture for dataset generation in common tests #932

Merged

Conversation

awinml
Copy link
Contributor

@awinml awinml commented Oct 28, 2022

Reference Issue

Fixes #672

What does this implement/fix? Explain your changes.

  • Created a common fixture to create a sample dataset used in tests.
  • Replaced boilerplate code with fixture in necessary tests in estimator_checks.py.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Patch coverage: 93.33% and project coverage change: -3.25 ⚠️

Comparison is base (8a42dfc) 96.51% compared to head (9f8d6a6) 93.26%.

❗ Current head 9f8d6a6 differs from pull request most recent head 41a726d. Consider uploading reports for the commit 41a726d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
- Coverage   96.51%   93.26%   -3.25%     
==========================================
  Files         103       94       -9     
  Lines        7280     6204    -1076     
  Branches     1071      666     -405     
==========================================
- Hits         7026     5786    -1240     
- Misses        147      356     +209     
+ Partials      107       62      -45     
Impacted Files Coverage Δ
imblearn/utils/estimator_checks.py 95.05% <93.33%> (+2.82%) ⬆️

... and 91 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@awinml awinml changed the title ENH Add fixture in common tests WIP ENH Add fixture in common tests Nov 3, 2022
@awinml awinml force-pushed the common_fixture_estimator_checks branch from 9f8d6a6 to c83dd0c Compare March 24, 2023 12:34
@awinml awinml changed the title WIP ENH Add fixture in common tests [MRG] ENH Add fixture in common tests Mar 24, 2023
@awinml
Copy link
Contributor Author

awinml commented Mar 24, 2023

@glemaitre Requesting a review. Please can you have a look at the code?

I have added the fixture to create a sample dataset that can be used by all the tests.

@awinml
Copy link
Contributor Author

awinml commented Mar 24, 2023

The CI fails on unrelated tests. Running the complete test suite locally does not give any errors.

@glemaitre glemaitre self-requested a review July 8, 2023 19:54
@glemaitre glemaitre changed the title [MRG] ENH Add fixture in common tests MAINT Add fixture for dataset generation in common tests Jul 8, 2023
@glemaitre
Copy link
Member

A bit late to the party but LGTM. I sync with main. It should be OK now.

@glemaitre glemaitre merged commit 3a7633d into scikit-learn-contrib:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fixture in common tests and speed them up
2 participants