-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Add fixture for dataset generation in common tests #932
MAINT Add fixture for dataset generation in common tests #932
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 96.51% 93.26% -3.25%
==========================================
Files 103 94 -9
Lines 7280 6204 -1076
Branches 1071 666 -405
==========================================
- Hits 7026 5786 -1240
- Misses 147 356 +209
+ Partials 107 62 -45
... and 91 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
9f8d6a6
to
c83dd0c
Compare
@glemaitre Requesting a review. Please can you have a look at the code? I have added the fixture to create a sample dataset that can be used by all the tests. |
The CI fails on unrelated tests. Running the complete test suite locally does not give any errors. |
A bit late to the party but LGTM. I sync with main. It should be OK now. |
Reference Issue
Fixes #672
What does this implement/fix? Explain your changes.
estimator_checks.py
.