-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Removing duplicate examples and cross-referencing #471
Merged
glemaitre
merged 5 commits into
scikit-learn-contrib:master
from
glemaitre:is/cleanup_examples
Sep 11, 2018
Merged
DOC: Removing duplicate examples and cross-referencing #471
glemaitre
merged 5 commits into
scikit-learn-contrib:master
from
glemaitre:is/cleanup_examples
Sep 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@chkoar Would you agree with this PR? |
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 79 79
Lines 4769 4769
=======================================
Hits 4705 4705
Misses 64 64
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the examples for each samplers since that we have an example presenting comparison of those which is much better. It would be better to have applications examples which are more constructive.
Cross-referencing is already done using
sphinx-gallery
. Therefore, I think that we can remove the cross-references.