Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Removing duplicate examples and cross-referencing #471

Merged
merged 5 commits into from
Sep 11, 2018

Conversation

glemaitre
Copy link
Member

I removed the examples for each samplers since that we have an example presenting comparison of those which is much better. It would be better to have applications examples which are more constructive.

Cross-referencing is already done using sphinx-gallery. Therefore, I think that we can remove the cross-references.

@pep8speaks
Copy link

pep8speaks commented Sep 10, 2018

Hello @glemaitre! Thanks for updating the PR.

Line 94:80: E501 line too long (80 > 79 characters)

Comment last updated on September 11, 2018 at 21:49 Hours UTC

@glemaitre
Copy link
Member Author

@chkoar Would you agree with this PR?

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          79       79           
  Lines        4769     4769           
=======================================
  Hits         4705     4705           
  Misses         64       64
Impacted Files Coverage Δ
...rototype_selection/_instance_hardness_threshold.py 100% <ø> (ø) ⬆️
imblearn/ensemble/_balance_cascade.py 100% <ø> (ø) ⬆️
...ling/_prototype_selection/_random_under_sampler.py 100% <ø> (ø) ⬆️
imblearn/combine/_smote_tomek.py 100% <ø> (ø) ⬆️
...rototype_selection/_neighbourhood_cleaning_rule.py 100% <ø> (ø) ⬆️
...nder_sampling/_prototype_selection/_tomek_links.py 100% <ø> (ø) ⬆️
imblearn/ensemble/_easy_ensemble.py 100% <ø> (ø) ⬆️
...rototype_selection/_condensed_nearest_neighbour.py 100% <ø> (ø) ⬆️
...n/under_sampling/_prototype_selection/_nearmiss.py 98.68% <ø> (ø) ⬆️
imblearn/over_sampling/_adasyn.py 98.57% <ø> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b624c...e9fd3a9. Read the comment docs.

@glemaitre glemaitre merged commit 7f93dfc into scikit-learn-contrib:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants