Minor rephrasing in the combine doc #330
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 68 68
Lines 4299 4299
=======================================
Hits 4224 4224
Misses 75 75Continue to review full report at Codecov.
|
|
Thanks a lot!!! |
|
@rasbt Big kudos !!!! thanks. |
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Oct 9, 2017
* minor rephrasing in the combine doc * Update combine.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this implement/fix? Explain your changes.
I just noticed the new release and was reading through the new documentation, which is really awesome! While reading, I found the description on combining under- and over-sampling methods a bit hard to read due to some minor typos and though rephrasing it a bit would help.
Any other comments?