[MRG] adding make_imbalance function #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chkoar @glemaitre, thoughts? |
| y_resampled : ndarray, shape (n_samples_new) | ||
| The corresponding label of `X_resampled` | ||
| """ | ||
| if ratio <= 0.0 or ratio >= 1.0: |
There was a problem hiding this comment.
I would check the function _validate_ratio to be sure about the boundary values.
|
It seems fine for me. I would maybe add some verbose using the logger maybe. If I remember, it look like what you were speaking in the gitter. |
|
LGTM! After this PR could we address the problem with #113? |
glemaitre
changed the title
Merged
christophe-rannou
pushed a commit
to christophe-rannou/imbalanced-learn
that referenced
this pull request
Apr 3, 2017
[MRG] adding make_imbalance function
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
[MRG] adding make_imbalance function
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
[MRG] adding make_imbalance function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function
make_imbalanceto help artificially generate imbalance data from a given dataset.This might be helpful for experiments, and for our toy problems and experiments.
included tests and example (image bellow).