Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT compatibility sklearn 1.4 #1058

Merged
merged 7 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
glemaitre committed Jan 19, 2024
commit 989f1c2fbd7ffa9497c875971e9842bb2fae87e3
2 changes: 1 addition & 1 deletion imblearn/over_sampling/_smote/tests/test_smoten.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def test_smoten_sparse_input(data, sparse_format):
https://github.com/scikit-learn-contrib/imbalanced-learn/issues/971
"""
X, y = data
X = OneHotEncoder(sparse_output=False).fit_transform(X)
X = OneHotEncoder().fit_transform(X).toarray()
X = _convert_container(X, sparse_format)

with pytest.warns(DataConversionWarning, match="is not really efficient"):
Expand Down
3 changes: 2 additions & 1 deletion imblearn/utils/tests/test_param_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from sklearn.utils import deprecated

from imblearn._config import config_context, get_config
from imblearn.base import _ParamsValidationMixin
from imblearn.utils._param_validation import (
HasMethods,
Hidden,
Expand Down Expand Up @@ -62,7 +63,7 @@ def _deprecated_method(self, a):
"""A deprecated validated method"""


class _Estimator(BaseEstimator):
class _Estimator(_ParamsValidationMixin, BaseEstimator):
"""An estimator to test the validation of estimator parameters."""

_parameter_constraints: dict = {"a": [Real]}
Expand Down
Loading