Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improve documentation for ENN and variants #1024

Merged

Conversation

solegalli
Copy link
Contributor

related to #850

separating in smaller PRs as requested.

Here I modify all docstrings, but since parameters are the same, you'll see that is the same changes in each class.

@solegalli
Copy link
Contributor Author

@glemaitre ready for review

@glemaitre glemaitre changed the title update docstrigs of ENN and variants DOC improve documentation for ENN and variants Jul 10, 2023
solegalli and others added 4 commits July 11, 2023 11:09
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@solegalli
Copy link
Contributor Author

done!

@glemaitre glemaitre merged commit 9a59070 into scikit-learn-contrib:master Jul 11, 2023
@glemaitre
Copy link
Member

The linter and some CIs passed. LGTM. Thanks @solegalli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants