DOC improve ENN documentation #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solegalli
force-pushed
the
update_ENN_and_variants
branch
from
87b5761 to
35ffdf9
Compare
|
@glemaitre ready for review |
glemaitre
reviewed
Jul 10, 2023
doc/under_sampling.rst
Outdated
| :class:`EditedNearestNeighbours` carries out the following steps: | ||
|
|
||
| 1. Train a KNN using the entire dataset. | ||
| 2. Find each observations' 3 closest neighbours (only for the targeted classes). |
There was a problem hiding this comment.
Almost sure that the 3 is parametrizable. We should instead refer to the sampler argument.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
done! |
glemaitre
reviewed
Jul 11, 2023
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
I missed that one, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #850
separating in smaller PRs as requested.