DOC improve introduction to undersampling methods #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glemaitre ready for review |
glemaitre
changed the title
glemaitre
approved these changes
Jul 10, 2023
doc/under_sampling.rst
Outdated
| You can refer to | ||
| :ref:`sphx_glr_auto_examples_under-sampling_plot_comparison_under_sampling.py`. | ||
| One way of handling imbalanced datasets is to reduce the number of observations from | ||
| the majority class or classes. The most well known algorithm in this group is random |
There was a problem hiding this comment.
the majority class or classes
I think it is a bit weird to say majority classes since usually we would refer to a single class. What about saying something like:
"reduce the number of observations from all classes but the minority class (i.e. the one with the least number of observations)."
doc/under_sampling.rst
Outdated
| We will discuss the different algorithms throughout this document. | ||
|
|
||
| Refer to :ref:`sphx_glr_auto_examples_under-sampling_plot_comparison_under_sampling.py` | ||
| for a comparison of the different undersampling methodologies. |
There was a problem hiding this comment.
I don't think that we this sentence because sphinx will use the title which is already stating "Compare under-sampling samplers".
There was a problem hiding this comment.
Not sure I understand this suggestion, but let me try a fix
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #853
As per request, splitting into smaller PRs