Skip to content

perf: faster reading of files with many branches #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025
Merged

perf: faster reading of files with many branches #1448

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
401ec6f
Use branch names directly
ariostas Jun 11, 2025
b8725c6
Use offset instead of index for cache_key
ariostas Jun 11, 2025
78362d1
Use branch name directly only if it's alphanumeric
ariostas Jun 12, 2025
cf48ed4
Implement better computation for index of branches
ariostas Jun 12, 2025
459d970
Added explanation for caching of index of all parent branches
ariostas Jun 13, 2025
6d55f75
Better check to see if branchname is valid expression
ariostas Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/uproot/behaviors/TBranch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1965,7 +1965,9 @@ def cache_key(self):
"""
if self._cache_key is None:
sep = ":" if isinstance(self._parent, uproot.behaviors.TTree.TTree) else "/"
self._cache_key = f"{self.parent.cache_key}{sep}{self.name}({self.index})"
self._cache_key = (
f"{self.parent.cache_key}{sep}{self.name}({self.member('fOffset')})"
)
return self._cache_key

@property
Expand Down Expand Up @@ -2923,7 +2925,7 @@ def _regularize_expressions(
):
_regularize_expression(
hasbranches,
language.getter_of(branchname),
branchname,
keys,
aliases,
language,
Expand Down
Loading