-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various RNTuple fixes #1191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I've scanned through everything and it's clear and self-explanatory. It looks like some dtypes changed, or maybe they're only getting tested now.
Please merge this to confirm that you're done with the PR. Thanks!
FYI, one of the tests in tests/test_1191_rntuple_fixes.py is pretty slow. My test-runner seemed to be stuck indefinitely, so I reran it with
Maybe it was stuck downloading http://root.cern/files/tutorials/ntpl004_dimuon_v1rc2.root. We have a pytest -m "not network" tests to exclude them on a quick-test run. That would be good to add, in the future. |
Ah okay, sorry about that. I'll try to find/generate a replacement file. Thanks @jpivarski |
Very simple RNTuple files can be read, but currently there are issues reading more complex files. In this PR, I'll be working towards fixing as many issues as I can find. I'll update this description with more information once it's ready for review.