feat: update the executor submit interface to take keyword arguments and be compatible with concurrent.futures.ThreadPoolExecutor
#1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobis
changed the title
concurrent.futures.ThreadPoolExecutor`concurrent.futures.ThreadPoolExecutor
Closed
lobis
commented
Oct 19, 2023
src/uproot/source/futures.py
Outdated
| """ | ||
| Pass the ``task`` and ``args`` onto the workers' | ||
| :ref:`uproot.source.futures.Worker.work_queue` as a | ||
| :doc:`uproot.source.futures.Future` so that it will be executed when | ||
| one is available. | ||
| """ | ||
| future = Future(task, args) | ||
| future = Future(task, *args, **kwargs) |
There was a problem hiding this comment.
I think this may cause some problems.
There was a problem hiding this comment.
It did, now it's fixed. Perhaps there is a better way to interface this.
jpivarski
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
This is good—the Python 3 Executor protocol has a / in the argument list, though this wasn't possible in Python 2.
This is a net improvement and can't break anything (except possible users of uproot.source.futures.*Executor outside of Uproot, though they should be using the Python standard library instead).
I'll merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing arguments to the tasks as positional, this makes some of the fsspec sources behave differently because they may have different number / order of arguments.
I also modified the definitions to keep the same as
concurrent.futures.ThreadPoolExecutor.I noticied after debugging #999 failure.