-
Notifications
You must be signed in to change notification settings - Fork 17
feat: use 1.13.0 from Kitware fork #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
for more information, see https://pre-commit.ci
I just shared feedback with the CMake team explaining the situation. In a nutshell, I mentioned it would be ideal to update the Kitware fork based of version
I will follow-up once we discussed it and settle on a path forward. |
The PR for |
Ditto. Here is what we discussed with @bradking
Switching to the updated Kitware fork with the backported classic job server is then a sensible path forward. |
The test failing on Windows seems to be coming from the jobserver patch in Kitware fork which does not make the test expected result depend on the platform: Kitware/ninja@8879a03#diff-4a3129d062b73d6f6436e3d4e5e3f41bbb848ef49cce54309fe6a00b6f93d132 c.f. Kitware/ninja#3 |
Ran
nox -s bump -- --upstream-repository Kitware/ninja
.The Kitware fork adds the following feature compared to upstream:
make-4.3-jobserver-1
: Based on this release, which includes pipe-based jobserver support for Make 4.3 and was conveniently created by the same developer who upstreamed jobserver support