feat: first draft #1
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
README.md
Outdated
| the API listed in the next section. | ||
|
|
||
| ```toml | ||
| [tool.dynamic-metadata.v1] |
There was a problem hiding this comment.
May be worth adding a note explaining why there is v1
README.md
Outdated
| [project] | ||
| dynamic = ["version"] | ||
|
|
||
| [tool.dynamic-metadata.v1.version] |
There was a problem hiding this comment.
... because it may be confusing to see .v1.version without providing some context.
|
Thanks for putting this together 💯 Exciting to see this moving forward. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
henryiii
force-pushed
the
henryiii/feat/draft
branch
from
cfc7199 to
e615723
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Based on scikit-build/dynamic-metadata#1 (with some updates). Fixes #435. This doesn't start using `tool.dynamic-metadata` yet, to give us room to change that. Plus we have to back-compat support `tool.scikit-build.metadata`, so might as well keep that as the only way to set this for now. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/draft
branch
from
5f5c00a to
1379043
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
| msg = "No inline configuration is supported" | ||
| raise ValueError(msg) | ||
|
|
||
| from setuptools_scm import Configuration, _get_version |
There was a problem hiding this comment.
pypa/setuptools-scm#904 hopefully restores compatibility until VCS versioning Will hopefully provide a own plugin
|
Let's:
Then, let's see in a followup if we can support accessing the existing values (like version from readme), or at least make sure it can be done. Also, let's mention "built-in" plugin support (mostly for future PEP plans). |
README.md
Outdated
|
|
||
| ```python | ||
| def dynamic_wheel(field: str, settings: Mapping[str, Any] | None = None) -> bool: | ||
| ... # Return true if metadata can change from SDist to whlee (METADATA 2.2 feature) |
There was a problem hiding this comment.
| ... # Return true if metadata can change from SDist to whlee (METADATA 2.2 feature) | |
| ... # Return true if metadata can change from SDist to wheel (METADATA 2.2 feature) |
* small-changes to draft * chore: WiP warning, readme
Working on first draft.