Skip to content

Conversation

scikit-build-app-bot[bot]
Copy link
Contributor

@scikit-build-app-bot scikit-build-app-bot bot commented Aug 6, 2025

Created by update_cmake_version.py

PR generated by "Update CMake" workflow.

@scikit-build-app-bot scikit-build-app-bot bot force-pushed the update-cmake-pr branch 2 times, most recently from 0fee86c to 409159f Compare August 8, 2025 06:26
@henryiii
Copy link
Contributor

henryiii commented Aug 9, 2025

Some GLIBC 32-bit platforms fail with CMake Error: Cannot parse SOURCE_DATE_EPOCH as integer (ARMv7l and i686).

@mayeut
Copy link
Contributor

mayeut commented Aug 9, 2025

The macro defined by CMake (and the test added) for 64-bit time only works on glibc 2.34+
We can likely ignore the test failure for now, it's not a regression. However, we might want to propose a package not affected by the year 2038 issue but there are likely more ecosystem wide implications with that:

  • armv7l:
    we currently use a manylinux_2_31 image (Ubuntu 20.04 based), Debian 11 also uses the same glibc and is still supported. We could add a manyliinux_2_35 image (which does not exist yet) and monitor download counts to decide when to drop 2.31.
  • i686:
    I'm not sure we'll be able to drop easily/short-term older glibc as those are likely the one being used for i686 and thus, adding a manylinux_2_34 package might not really make sense right now ?

@henryiii
Copy link
Contributor

henryiii commented Aug 9, 2025

That’s only the issue for one of them, the other I reported here: https://gitlab.kitware.com/cmake/cmake/-/issues/27129

mayeut added 2 commits August 10, 2025 09:10
Architecture ID is not detected properly for gfortran on Ubuntu 20.04 armhf
@mayeut
Copy link
Contributor

mayeut commented Aug 10, 2025

That’s only the issue for one of them

the 64-bit time issue also exists for the manylinux_armv7l build, we just don't get to this point because of the second issue.
I'll add some comments in the issue upstream.

@henryiii henryiii enabled auto-merge (squash) August 11, 2025 14:29
@henryiii henryiii merged commit e057480 into main Aug 11, 2025
55 checks passed
@henryiii henryiii deleted the update-cmake-pr branch August 11, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants