Skip to content

Make verify_gpg_settings respect --skip-gpg #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Conversation

ehrenfeu
Copy link
Contributor

No sure whether it is intended to work that way, but for me the --skip-gpg parameter didn't do the job. Locally, the change in this PR works fine, but I am definitely lacking the global picture of maven + travis + OSS Sonatype / ...

@ctrueden
Copy link
Member

ctrueden commented Apr 10, 2018

@ehrenfeu Sorry, that is just some cruft left over from the old-style release-version.sh script, which performed the actual release and deployed it using your local machine.

The new way is that Travis has the GPG key and does the build+deploy. So you should never need the GPG stuff on your local system.

I'll look into completely removing that logic.

Edit: Actually, it looks like I already updated that logic to check whether Travis will be happy when release time happens.

Why do you need to skip this check, @ehrenfeu? Is there some reason we can't commit an encrypted signing key to your repo?

@ctrueden ctrueden merged commit cb2db29 into scijava:master Apr 10, 2018
@ctrueden
Copy link
Member

I merged it, in the interest of the script working as described. But I still wonder whether you really need to use this flag, @ehrenfeu. Any repository that uses this script needs the ImageJ Maven repository credentials encrypted at minimum, and ideally the GPG key as well, in case the component ever migrates to OSS Sonatype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants