-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dates not sorting full string #973
Comments
Prior to this commit when the date_created property was indexed, only the year was indexed. If the input was something like "2024-01-01" then `date_ssi` would only be "2024". This commit will index YYYY-MM-DD, YYYY-MM, and YYYY if given. Anything other than those three formats will be indexed as is and won't work correctly with sorting or range queries. Ref: - #973
Prior to this commit when the date_created property was indexed, only the year was indexed. If the input was something like "2024-01-01" then `date_ssi` would only be "2024". This commit will index YYYY-MM-DD, YYYY-MM, and YYYY if given. Anything other than those three formats will be indexed as is and won't work correctly with sorting or range queries. Ref: - #973
Prior to this commit when the date_created property was indexed, only the year was indexed. If the input was something like "2024-01-01" then `date_ssi` would only be "2024". This commit will index YYYY-MM-DD, YYYY-MM, and YYYY if given. Anything other than those three formats will be indexed as is and won't work correctly with sorting or range queries. Ref: - #973
SoftServ QA: ✅ It did sort the works correctly via the date created. |
In this collection (https://wabash.hykucommons.org/collections/d4efac9d-24d2-472e-85cd-1c7da1319ccd?utf8=%E2%9C%93&sort=date_ssi+desc&per_page=10&locale=en), works with properly structured dates are still sorting the days out of order. |
The reindex did not complete correctly.
|
We reindex the collection of concern and see the issue got resolved so perhaps there were some issues when we reindexed before. We will need to run another reindex over the weekend. |
Summary
In some cases, dates in the Date Created field fomatted as yyyy-mm-dd are only sorting by part of the string. Example here: https://wabash.hykucommons.org/collections/d4efac9d-24d2-472e-85cd-1c7da1319ccd?utf8=%E2%9C%93&sort=date_ssi+desc&per_page=10&locale=en
Relevant Slack thread: https://assaydepot.slack.com/archives/C0313NKC08L/p1708455332886429
Acceptance Criteria
Testing Instructions
The text was updated successfully, but these errors were encountered: