Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk uploads for Bulkrax #858

Open
ShanaLMoore opened this issue Oct 24, 2024 · 1 comment
Open

Chunk uploads for Bulkrax #858

ShanaLMoore opened this issue Oct 24, 2024 · 1 comment
Assignees
Labels
blocked other work must be completed first

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 24, 2024

Summary

related:

Acceptance Criteria

  • [ ]

Screenshots or Video

Testing Instructions

To be filled out by dev

Notes

ShanaLMoore added a commit to samvera/bulkrax that referenced this issue Oct 25, 2024
… and efficiency

Issue:
- scientist-softserv/adventist_knapsack#858

Chunked uploads allow large files to be uploaded in smaller parts, addressing common issues with file size limits, network interruptions, and server resource management.

This change supports smoother, more reliable uploads for large files in Bulkrax.
@ShanaLMoore ShanaLMoore self-assigned this Oct 29, 2024
ShanaLMoore added a commit to samvera/bulkrax that referenced this issue Oct 30, 2024
…#982)

* [i858] - Enables chunked uploads for improved file upload reliability and efficiency

Issue:
- scientist-softserv/adventist_knapsack#858

Chunked uploads allow large files to be uploaded in smaller parts, addressing common issues with file size limits, network interruptions, and server resource management.

This change supports smoother, more reliable uploads for large files in Bulkrax.

* Adds Hyrax file uploader to bagit, and xml partial

* ♻️ Move common code into a shared partial

* 🎁 Adds custom js validations to add/remove required attr

* Update importers_controller_spec.rb

* remove upperbound for Hyrax version

* bump versions to make bundling on arm processors work again

* ✅ adds Hyrax::UploadedFile context to importers controller spec

* ♻️ Move Bulkrax uploader logic to importers.js and ensure conditional initialization

- Moved Bulkrax file upload logic from bulkrax.js to importers.js to consolidate related logic
- Added conditional check to initialize uploader only if `hyraxUploader` is defined as a function
- Ensured toggle of 'required' attribute based on uploaded file presence for import form consistency

* re add deleted comments

---------

Co-authored-by: Rob Kaufman <rob@notch8.com>
@ShanaLMoore ShanaLMoore added the blocked other work must be completed first label Oct 31, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Nov 4, 2024

Marked blocked because upgrading hyku's bulkrax results in 5 failing specs on the pipeline. These specs aren't failing locally though.

cc @orangewolf to look this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked other work must be completed first
Projects
None yet
Development

No branches or pull requests

2 participants